Add support for product_mapping in promotional offers
#4489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
approved these changes
Nov 15, 2024
RevenueCatUI/CustomerCenter/Data/LoadPromotionalOfferUseCase.swift
Outdated
Show resolved
Hide resolved
RevenueCatUI/CustomerCenter/Data/LoadPromotionalOfferUseCase.swift
Outdated
Show resolved
Hide resolved
Comment on lines
+80
to
+86
| let discount = if !promoOfferDetails.productMapping.isEmpty { | ||
| findMappedDiscount(for: product, | ||
| productIdentifier: productIdentifier, | ||
| promoOfferDetails: promoOfferDetails) | ||
| } else { | ||
| findLegacyDiscount(for: product, promoOfferDetails: promoOfferDetails) | ||
| } |
There was a problem hiding this comment.
TIL let foo = if ... else works. I would have used a ternary but I feel like this might be more readable
RevenueCatUI/CustomerCenter/Data/LoadPromotionalOfferUseCase.swift
Outdated
Show resolved
Hide resolved
Comment on lines
+112
to
+114
| if let exactMatch = product.discounts.first(where: { | ||
| $0.offerIdentifier == promoOfferDetails.iosOfferId | ||
| }) { |
There was a problem hiding this comment.
FFTI, but you can also do it like this
Suggested change
| if let exactMatch = product.discounts.first(where: { | |
| $0.offerIdentifier == promoOfferDetails.iosOfferId | |
| }) { | |
| if let exactMatch = product.discounts.first { | |
| $0.offerIdentifier == promoOfferDetails.iosOfferId | |
| } { |
Then again maybe the brackets add some clarity since it ends in a { too
There was a problem hiding this comment.
It actually fails because of the ending {
RevenueCatUI/CustomerCenter/Data/LoadPromotionalOfferUseCase.swift
Outdated
Show resolved
Hide resolved
fire-at-will
approved these changes
Nov 15, 2024
vegaro
deleted the
sdk-3631-sdk-ignoring-product_mapping-in-promotional-offers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a new
product_mappingfield in thepromotional_offerJSON object. This map is more specific on which offer to load. This mapping will be configurable with the new UI, but we should still support the oldios_offer_idin case the developer has not configured a mapping yet.