Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy for internal hubot #6957

Closed
akleandrov opened this issue May 12, 2017 · 7 comments
Closed

Proxy for internal hubot #6957

akleandrov opened this issue May 12, 2017 · 7 comments

Comments

@akleandrov
Copy link

How set proxy (manual or use http_proxy) for internal hubot?

Rocket.Chat Version: 0.54.2
Running Instances: 1
Node Version: v4.7.3

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented May 17, 2017

Being that this is internal. Rocket.Chat wide proxy settings should effect this. This is also needed for #2657

@soulstyless but in general if you use the environment variable: HTTP_PROXY set to the url of your proxy it should work

@fcoppolani
Copy link

fcoppolani commented May 30, 2017

Hi, thanks @geekgonecrazy for this workaround. Unfortunately this way all requests go through our proxy (locahost included and thus fail). We tried to use NO_PROXY environnement variable ( https://wiki.archlinux.org/index.php/proxy_settings ), but it seems rocket.Chat (or one of its components) does not take it into account.
If you have any insight about this matter I will look forward to read it :)

Maybe linked to (My knowledge of rocket.Chat component is not good enough to ensure it is linked) : meteor/meteor#5417

@geekgonecrazy
Copy link
Contributor

@fcoppolani if you export the variable then yes they would. I would recommend passing this environment variable explicitly to rocket.chat.

Something like: HTTP_PROXY=value node main.js in what ever start up script / daemon you are using.

@fcoppolani
Copy link

fcoppolani commented Jun 1, 2017

Thanks for you reply @geekgonecrazy , that is what we have done, HTTP_PROXY works well but everything pass through it (even the localhost requests used by rocket.chat). So we tried the NO_PROXY but this last one is not taken into account (we still see the localhost request coming into our proxy).

@geekgonecrazy
Copy link
Contributor

hm.. from a quick search it looks like this NO_PROXY is widely requested across many frameworks. But seems to not be baked in with nodejs like HTTP_PROXY is.

@timkinnane
Copy link
Contributor

@geekgonecrazy was this resolved? Looks like it but I'm not sure if there's changes required to the internal hubot?

@MartinSchoeler
Copy link
Member

Please move this to the rocket.chat forums. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants