Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing proxy settings for fetching external pages #2657

Closed
netdevfighter opened this issue Mar 27, 2016 · 15 comments
Closed

Missing proxy settings for fetching external pages #2657

netdevfighter opened this issue Mar 27, 2016 · 15 comments
Assignees
Milestone

Comments

@netdevfighter
Copy link
Contributor

We use the rocket chat on an internal network without direct internet access (is blocked by firewall) but we can use a proxy for access it (only for external networks/pages).

Is it possible to implement proxy (external destination) and no proxy (internal destination)?

That would be pretty cool for link previews (for example).

@engelgabriel
Copy link
Member

I believe this depends on #2555

@engelgabriel engelgabriel added this to the 0.25.0 milestone Mar 28, 2016
@engelgabriel engelgabriel modified the milestones: 0.25.0, 0.26.0, 0.27.0 Apr 5, 2016
@marceloschmidt marceloschmidt modified the milestone: 0.27.0 Apr 18, 2016
@marceloschmidt marceloschmidt added the Feature: Request Requested Feature label May 2, 2016
@zbyte
Copy link

zbyte commented Mar 3, 2017

same issue

@zbyte
Copy link

zbyte commented May 11, 2017

Will it ever been done?

@marceloschmidt marceloschmidt added type: discussion Feature: Planned Planned Feature and removed Feature: Request Requested Feature labels May 24, 2018
@marceloschmidt marceloschmidt added this to the 0.67.0 milestone May 24, 2018
@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 20, 2018
@theorenck theorenck modified the milestones: 0.68.0, Short-term Jul 31, 2018
@Abraka
Copy link

Abraka commented Mar 22, 2019

Any progress on this?

@engelgabriel engelgabriel modified the milestones: Short-term, 1.1.0 Mar 22, 2019
@marceloschmidt
Copy link
Member

I'm not sure I understand the request. Are you interested in a server-side proxy? Because afaict, image and link preview happens on the server side, so a proxy on the client-side wouldn't make much sense.

@Abraka
Copy link

Abraka commented May 9, 2019

No, we just simply want a option in administration interface of rocketchat... something like: http(s)proxy://"corporate.proxy.com". Description: Use this option for links and content-video preview if your installation cannot reach internet directly.
Do not confuse this for system wide option of http_proxy which could cause internals components of rocketchat to communicate between each other through this proxy, which is very unwelome scenario.

@marthydavid
Copy link

Hi
I've just found this PR #11124
Is it helpful?

@Abraka
Copy link

Abraka commented Jun 14, 2019

well, function description looks similar...what scares me here is that request is over year old!

@idl0r
Copy link

idl0r commented Jul 5, 2019

That'd be really cool. We'd like to use a proxy.

@fcoppolani
Copy link

Yes still need it, keep it alive !

@engelgabriel engelgabriel modified the milestones: 1.1.0, 1.3.0 Jul 10, 2019
@marthydavid
Copy link

Hi!
What do you think about this?
develop...marthydavid:2657-RocketChat-Proxy-Support

@sampaiodiego sampaiodiego modified the milestones: 1.3.0, 1.4.0 Jul 25, 2019
@Paulpatou
Copy link

No news ?

@engelgabriel engelgabriel modified the milestones: 2.0.0, 2.2.0 Oct 13, 2019
@Paulpatou
Copy link

??

@engelgabriel engelgabriel modified the milestones: 2.2.0, 4.1.0 Mar 17, 2020
@Weuxel
Copy link

Weuxel commented Jan 18, 2022

After Log4Shell, security has tightened. Internet access via proxy is mandatory now.
Please provide a proxy setting

@bellegarde-c
Copy link

Was working previously but breaks in 4.4.0 :(

[Unit]
Description=The Rocket.Chat server
After=network.target mongod.service
[Service]
ExecStartPre=/bin/sleep 30
ExecStart=/usr/local/bin/node /opt/Rocket.Chat/main.js
StandardOutput=syslog
StandardError=syslog
SyslogIdentifier=rocketchat
User=rocketchat
Environment=http_proxy=http://srv-proxy-1.********************:3128 https_proxy=http://srv-proxy-1.********************:3128 MONGO_URL=mongodb://localhost:27017/rocketchat?replicaSet=rs01 MONGO_OPLOG_URL=mongodb://localhost:27017/local?replicaSet=rs01 ROOT_URL=https://rocket****************** PORT=3001
[Install]
WantedBy=multi-user.target

Any idea ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests