Provide a way to change a person's real name #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if user.name is name | ||
| return name | ||
|
|
||
| if not /^[0-9a-zA-Z-_. ]+$/.test name |
There was a problem hiding this comment.
Name should allow the real user name, so I think only trim the name and verify is empty is the correct way
|
@graywolf336 This PR has conflict now, can you solve it? |
|
@rodrigok Done, mind taking another look? Not sure why the |
rodrigok
added a commit
that referenced
this pull request
Oct 23, 2015
Provide a way to change a person's real name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to change a person's "name" which they entered when registering for the website. This will allow people to change that via their account.