Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Attachments without dates were showing December 31, 1970 #13428

Merged
merged 5 commits into from
Mar 2, 2019
Merged

[FIX] Attachments without dates were showing December 31, 1970 #13428

merged 5 commits into from
Mar 2, 2019

Conversation

wreiske
Copy link
Contributor

@wreiske wreiske commented Feb 9, 2019

Closes #13427

Before
screen shot 2019-02-09 at 12 46 53 pm

After
screen shot 2019-02-09 at 12 46 22 pm

The Fix:
Wrap the time tag in an "unless" so it wont show if it is null.

{{#unless time}}
	<span class="time">
		{{time}}
	</span>
{{/unless}}

@ggazzo ggazzo added the ui/ux label Feb 10, 2019
@ggazzo ggazzo added this to the 0.75.0 milestone Feb 10, 2019
@frdmn frdmn mentioned this pull request Feb 14, 2019
Closed
@rodrigok rodrigok merged commit 474c918 into RocketChat:develop Mar 2, 2019
@rodrigok rodrigok changed the title [Fix] attachment dates that are null from showing December... [FIX] Attachments without dates were showing December 31, 1970 Mar 2, 2019
@wreiske wreiske mentioned this pull request Mar 13, 2019
Closed
@wreiske wreiske mentioned this pull request Apr 1, 2019
Closed
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees
No one assigned
Labels
ui/ux
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wreiske @rodrigok @ggazzo