Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set user's name to alias in message #3337

Merged
merged 3 commits into from Jul 8, 2016
Merged

Set user's name to alias in message #3337

merged 3 commits into from Jul 8, 2016

Conversation

ghost
Copy link

@ghost ghost commented May 24, 2016

@RocketChat/core

Related #1209

I think this solution is not perfect. However, this is easy and low cost.
I focused only to now and future messages. A message's alias not changed if a user has changed the name. But I thought that was okay anyway.

set-realname-to-alias

EDIT:
Add settings for this feature.

ss2

@ghost ghost changed the title Set user's realname to alias if not set already Set user's name to alias in message May 25, 2016
@tekwreck
Copy link

tekwreck commented Jun 6, 2016

Is this in master yet?

@hvma
Copy link

hvma commented Jun 7, 2016

status?

@chey
Copy link

chey commented Jun 9, 2016

What about using @{user}
I think using @ for name auto-completion should also look at the alias in this case.

@LFCavalcanti
Copy link

@chey
Like your idea, but in that case if there is no {name} would {user} be duplicated onto {name}?
This will happen for GitHub integration, where there is a nickname only for posting.

@chey
Copy link

chey commented Jun 9, 2016

@LFCavalcanti
When typing @ to look for a user the auto-complete box that comes up should be in this format.
{user} {name}
{user} {name}
etc.
as the user types, it can match either.
when the user chooses by either clicking or hitting enter key ... the {user} field gets put in the input box
pretty simple really. only minor ui changes i would think.

@graywolf336
Copy link
Contributor

@RocketChat/core Hey can we take a look at this? Will this effect performance in any way like was mentioned in #1209

@rodrigok
Copy link
Member

This will not affect the performance, but I don't know if it's what users expect from.

  1. If you change your name the old messages will keep the old name
  2. The auto complete will keep showing the username only

@RocketChat/core what do you think?

@imjustfly
Copy link

I think the alias should be shown in Members List, DIRECT MESSAGES and any area that shows users.

@rodrigok
Copy link
Member

rodrigok commented Jul 5, 2016

@imjustfly Alias is a message related thing, it's not a user property.

@bhbarbosa
Copy link

Curious to know if this will work on LDAP too, even if Alias is just used in message, it's a potential gain for environments like mine.

@richardwlu
Copy link

If we are on LDAP, how do we let users choose their own "name" so they have an alias but avoid it being in sync with LDAP; however, it is still important that email addresses/accounts sta up to date? We currently have the User Data Field Map as {"cn":"name", "mail":"email"}. When I change my name from the Account settings, it gets reset back since the "Sync Data" is on. But I'm assuming we need "Sync Data" on so users can log in? Please correct me if I am wrong.

@ghost ghost deleted the set-realname-to-alias branch September 5, 2017 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants