Add very basic bot interface #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grepsedawk
force-pushed
the
bot-interface
branch
from
9ec38d8 to
37fbf70
Compare
Gjum
reviewed
Jul 30, 2022
| @@ -65,9 +65,9 @@ class Rosegold::Clientbound::PlayerPositionAndLook < Rosegold::Clientbound::Pack | |||
|
|
|||
| Log.debug { "Position reset: #{player.feet} #{player.look} dismount=#{dismount_vehicle} flags=#{relative_flags}" } | |||
|
|
|||
| client.start_physics | |||
| client.physics.start | |||
There was a problem hiding this comment.
You're starting a new tick loop for every received PlayerPositionAndLook packet. The server sends this packet every time the client moves incorrectly. This will cause the client to sand way too many movement packets. I suggest going back to a nilable Client#physics that indicates when movement is possible.
There was a problem hiding this comment.
Ooh, good catch ~~ I'll make a fix for that by tracking state, but from a types perspective it works out a ton better to leave client.physics as a solid, non-nilable type otherwise we're dealing with physics.try &.method everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.