physics, groundwork for proxy and inventory #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g., to store and forward with proxy
Gjum
changed the title
grepsedawk
reviewed
Mar 31, 2023
grepsedawk
reviewed
Mar 31, 2023
grepsedawk
reviewed
Apr 1, 2023
grepsedawk
reviewed
Apr 1, 2023
grepsedawk
reviewed
Apr 1, 2023
grepsedawk
reviewed
Apr 1, 2023
grepsedawk
reviewed
Apr 1, 2023
grepsedawk
reviewed
Apr 1, 2023
grepsedawk
reviewed
Apr 1, 2023
grepsedawk
reviewed
Apr 1, 2023
grepsedawk
reviewed
Apr 1, 2023
grepsedawk
reviewed
Apr 1, 2023
grepsedawk
reviewed
Apr 1, 2023
grepsedawk
reviewed
Apr 1, 2023
| # Can be used for client and server. | ||
| # Caller of #read_packet must update #state= appropriately. | ||
| # Useless after disconnect; create a new instance to reconnect. | ||
| class Rosegold::Connection(InboundPacket, OutboundPacket) |
There was a problem hiding this comment.
Might be worth delegating missing methods from client.cr straight to this class 🤔
There was a problem hiding this comment.
Can this be done dynamically? Client#@connection's value changes when reconnecting, it may be nil, or its methods may be no-ops/raise an exception when not connected.
There was a problem hiding this comment.
Yeah it's a macro, something like delegate_missing_to
grepsedawk
reviewed
Apr 1, 2023
grepsedawk
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.