Change log statements to crystal stdlib logging #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Level can be controlled with LOG_LEVEL=DEBUG
Gjum
reviewed
Jul 18, 2022
| @@ -1,4 +1,6 @@ | |||
| class Rosegold::Clientbound::Chat < Rosegold::Clientbound::Packet | |||
| Log = ::Log.for(self) | |||
There was a problem hiding this comment.
Can you explain why this gets its own log instance but the other packets don't? Just curious.
There was a problem hiding this comment.
Because you added the [Chat] prefix, this gives the chat a prefix based on the class so we know it's chat (and I deleted [Chat])
There was a problem hiding this comment.
We'll also be able to add formatters for specific ones if we chose, but this was the only one that needed it's own instance for now based on your existing messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Level can be controlled with LOG_LEVEL=DEBUG