Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UB in the vulkano example #1354

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix UB in the vulkano example #1354

merged 1 commit into from
Jun 13, 2024

Conversation

marc0246
Copy link
Contributor

Fixes #1340. This only works as of sdl2 0.36 and vulkano 0.34.

@kellerkindt
Copy link
Contributor

kellerkindt commented Feb 10, 2024 •
edited
Loading

@Cobrand As the original author of the hacky SurfaceApi::Xlib monstrosity, I am also in favor of merging this PR. I have tested Surface::from_window_ref with vulkano 0.34.1 locally on X11 and Wayland and it works just fine.

@Cobrand Cobrand merged commit 7596bbd into Rust-SDL2:master Jun 13, 2024
@marc0246 marc0246 deleted the vulkano-example branch June 13, 2024 09:53
@kellerkindt kellerkindt mentioned this pull request Sep 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect SurfaceApi for Vulkan example in readme
3 participants
@marc0246 @kellerkindt @Cobrand