Allow sdl2-sys to build for windows-gnu target #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Although I can't test on windows-msvc or windows-gnu, I'm sure that by merging this into master someone will notice an issue soon enough if that PR breaks anything! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to make a few small changes to the sdl2-sys build.rs to get linux-windows cross compilation working on my machine.
I'm not sure if outright disabling the GLES subsystem is acceptable but I know that by default, mingw doesn't come with GLES or EGL headers. So if you try building SDL from source without disabling it, it fails.
I noticed that SDL can provide it's own GLES headers but as far as I could tell they're only used if _MSC_VER is defined, and I figured defining that for a non-msvc target might be a bad idea.