This repository has been archived by the owner on Jan 5, 2022. It is now read-only.
Improve tests #50
Merged
Improve tests #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-richter
requested review from
marikaner,
mr-flannery and
FrankEssenberger
| conflicts.length > 1 | ||
| ? `Files with the names "${listOfFiles}" already exist. If you want to overwrite them, rerun the command with \`--force\`.` | ||
| : `A file with the name "${listOfFiles}" already exists. If you want to overwrite it, rerun the command with \`--force\`.`, | ||
| { exit: 1 } |
There was a problem hiding this comment.
In the new version the findConflixts return {exit: 11} e.g. add-approuter line 43.
FrankEssenberger
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
Clear improvement from the old try catch in the test. One remark though: In the old way the setting of the exit code is part of the method itself. So if you call it N time in the code always the same error is created. Now the error code is set in the catch of the method call. I wonder if this is good from a consistency point of view.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In an effort to remove the rather large 'cli-ux' package, I refactored a bit and came across some minor bugs and possible improvements in the tests.
Checklist