fix: Update model lists and model availability test #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonas-Isr
reviewed
Feb 24, 2025
foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiModel.java
Show resolved
Hide resolved
foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiModel.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Should we also deprecate models that are deprecated by AI Core but still usable?
https://me.sap.com/notes/3437766
@newtork
…nto update-openAI-models-and-test
|
sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/ScenarioTest.java
Outdated
Show resolved
Hide resolved
jjtang1985
previously requested changes
Feb 24, 2025
foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiModel.java
Outdated
Show resolved
Hide resolved
|
As discussed we'll propagate deprecation notices, may attach date hints. If our current embedding model is considered deprecated and we cannot simply switch, please consider creating a BLI to track progress and alignment with JS. |
Jonas-Isr
reviewed
Feb 25, 2025
sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/ScenarioTest.java
Outdated
Show resolved
Hide resolved
…and-test # Conflicts: # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/ScenarioTest.java
CharlesDuboisSAP
approved these changes
Feb 26, 2025
newtork
approved these changes
Feb 28, 2025
newtork
dismissed
jjtang1985’s stale review
I summarized our findings above. A BLI will be used to track progress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated