fix: Proxy-Authorization token expired issue for cached destination (…

…#5563)

* feat: use existing proxy authorization header if not expired

* fix: lint

* chore: add changeset

* fix: remove expiration check

* fix: lint

* fix: lint

* revert

.changeset/salty-teams-follow.md

@@ -0,0 +1,5 @@
+---
+'@sap-cloud-sdk/connectivity': patch
+---
+
+[Fixed Issue] Add `proxyConfiguration` on the fly to avoid expired proxy authorization token in cached destination if it lives shorter than the token for destination service.

packages/connectivity/src/scp-cf/connectivity-service.spec.ts

@@ -28,7 +28,7 @@ describe('connectivity-service', () => {
 
   it('adds a proxy configuration containing at least the host, the port, and the "Proxy-Authorization" header to a destination', async () => {
     mockServiceBindings();
-    mockServiceToken();
+    const serviceTokenSpy = mockServiceToken();
 
     const input: Destination = {
       url: 'https://example.com',
@@ -50,6 +50,7 @@ describe('connectivity-service', () => {
 
     const withProxy = await addProxyConfigurationOnPrem(input);
     expect(withProxy).toEqual(expected);
+    expect(serviceTokenSpy).toHaveBeenCalledTimes(1);
   });
 
   it('also contains the "SAP-Connectivity-Authentication" header if a JWT is present', async () => {

packages/connectivity/src/scp-cf/destination/destination-from-service.ts

@@ -116,7 +116,7 @@ export class DestinationFromServiceRetriever {
     setForwardedAuthTokenIfNeeded(destination, options.jwt);
 
     if (destinationResult.fromCache) {
-      return destination;
+      return da.addProxyConfiguration(destination);
     }
 
     if (!destination.forwardAuthToken) {
@@ -153,13 +153,13 @@ export class DestinationFromServiceRetriever {
       }
     }
 
-    const withProxySetting = await da.addProxyConfiguration(destination);
     const withTrustStore = await da.addTrustStoreConfiguration(
-      withProxySetting,
+      destination,
       destinationResult.origin
     );
     await da.updateDestinationCache(withTrustStore, destinationResult.origin);
-    return withTrustStore;
+
+    return da.addProxyConfiguration(withTrustStore);
   }
 
   private static throwUserTokenMissing(destination) {