Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Disable iasToXsuaaTokenExchange by default #5555

Merged

Conversation

ZhongpinWang
Copy link
Contributor

@ZhongpinWang ZhongpinWang commented Feb 24, 2025

Relates to SAP/ai-sdk-js-backlog#192.

  • I know which base branch I chose for this PR, as the default branch is v3-main now, which is not for v4 development.
  • If my change will be merged into the main branch (for v4), I've updated (V4-Upgrade-Guide.md)[./V4-Upgrade-Guide.md] in case my change has any implications for users updating to SDK v4

@ZhongpinWang ZhongpinWang changed the title feat: Disable ias to xsuaa token exchange by default feat!: Disable ias to xsuaa token exchange by default Feb 24, 2025
@ZhongpinWang ZhongpinWang marked this pull request as ready for review February 24, 2025 16:07
@ZhongpinWang ZhongpinWang changed the title feat!: Disable ias to xsuaa token exchange by default feat!: Disable iasToXsuaaTokenExchange by default Feb 25, 2025
Copy link
Contributor

@deekshas8 deekshas8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

Co-authored-by: Deeksha Sinha <[email protected]>
@ZhongpinWang ZhongpinWang merged commit 25c9dd8 into main Feb 27, 2025
16 checks passed
@ZhongpinWang ZhongpinWang deleted the feat-disable-ias-to-xsuaa-token-exchange-by-default branch February 27, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants