Fix: generator can handle enum type with one member #699
+133
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjtang1985
requested review from
marikaner,
FrankEssenberger and
florian-richter
jjtang1985
commented
Nov 10, 2020
| const types: EdmxEnumType[] = forceArray(root.EnumType); | ||
| return types.map(edmxEnumType => ({ | ||
| Name: edmxEnumType.Name, | ||
| Member: forceArray(edmxEnumType.Member) |
There was a problem hiding this comment.
When there is only one member, the type of the Member is an object instead of an array.
There was a problem hiding this comment.
That is essentially the fix, right? ;)
marikaner
approved these changes
Nov 11, 2020
| const types: EdmxEnumType[] = forceArray(root.EnumType); | ||
| return types.map(edmxEnumType => ({ | ||
| Name: edmxEnumType.Name, | ||
| Member: forceArray(edmxEnumType.Member) |
There was a problem hiding this comment.
That is essentially the fix, right? ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the issue reported here, where the generator fails when it detects a enum type with one element.