Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support customize shortcuts for checkbox selection/deselection #1663

Merged

Conversation

PoHengLinTW
Copy link
Contributor

Address the feature request for customized shortcuts in #1648.

(First time contribute, lmk if there is any suggestion)

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@9f535bd). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1663   +/-   ##
=======================================
  Coverage        ?   98.05%           
=======================================
  Files           ?       39           
  Lines           ?     2464           
  Branches        ?      657           
=======================================
  Hits            ?     2416           
  Misses          ?       41           
  Partials        ?        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@SBoudrias SBoudrias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's an amazing PR! Thanks for updating the documentation and the unit tests!

@SBoudrias SBoudrias merged commit 504c230 into SBoudrias:main Feb 2, 2025
11 checks passed
@PoHengLinTW PoHengLinTW deleted the support-checkbox-customize-shortcuts branch February 2, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants