Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that maxBufferSize property does not correctlly works for SDAnimatedImageView #2934

Merged
merged 1 commit into from
Jan 26, 2020

Conversation

dreampiggy
Copy link
Contributor

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: ...

Pull Request Description

Should setup the player's property

… for `SDAnimatedImageView`, should setup the player's property
@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #2934 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2934      +/-   ##
==========================================
- Coverage   83.94%   83.91%   -0.03%     
==========================================
  Files          69       69              
  Lines        7099     7105       +6     
==========================================
+ Hits         5959     5962       +3     
- Misses       1140     1143       +3
Flag Coverage Δ
#ios 84.05% <66.66%> (-0.02%) ⬇️
#macos 83.66% <66.66%> (-0.04%) ⬇️
#tvos 84.04% <66.66%> (-0.01%) ⬇️
Impacted Files Coverage Δ
SDWebImage/Core/SDAnimatedImageView.m 82.66% <66.66%> (-0.44%) ⬇️
SDWebImage/Core/SDWebImagePrefetcher.m 89.93% <0%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 443bf50...d565a37. Read the comment docs.

@dreampiggy dreampiggy requested a review from kinarobin January 26, 2020 10:34
@dreampiggy
Copy link
Contributor Author

@kinarobin This is a bug during the refactory from v5.3.0...But since it's not so serious as #2931. So I decide to just release on 5.5.2 patch version. No 5.3.x/5.4.x backward support.

@dreampiggy dreampiggy merged commit 3459cd2 into SDWebImage:master Jan 26, 2020
@dreampiggy dreampiggy deleted the bugfix_max_buffer_size branch January 26, 2020 10:36
@dreampiggy dreampiggy added this to the 5.5.2 milestone Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant