Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Icon documentation #68

Merged
merged 4 commits into from
Feb 10, 2022
Merged

Adds Icon documentation #68

merged 4 commits into from
Feb 10, 2022

Conversation

coreyhunt
Copy link
Contributor

This adds the documentation draft with text and screenshots.

@coreyhunt
Adds Icon documentation
aa4e425 
This adds the documentation draft with text and screenshots.
@coreyhunt coreyhunt requested a review from joni-f-g December 30, 2021 21:44
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-68 December 30, 2021 21:44 Inactive
@github-actions
Copy link

github-actions bot commented Dec 30, 2021 •
edited
Loading

Size Change: 0 B

Total Size: 123 kB

ℹ️ View Unchanged
Filename Size
dist/css/base.css 266 B
dist/css/components.css 875 B
dist/css/docs.css 1.34 kB
dist/css/fonts.css 169 B
dist/css/overrides.css 104 B
dist/css/sfds.css 45.4 kB
dist/css/typography.css 557 B
dist/css/utilities.css 44 kB
dist/js/docs.js 13.9 kB
dist/js/icons.js 8.29 kB
dist/js/sfds.js 8.29 kB

compressed-size-action

joni-f-g
joni-f-g reviewed Dec 31, 2021
View reviewed changes
@coreyhunt
Delete docs/foundations/assets directory
66df2cc 
Removes the unneeded assets directory since reference images will be directly added into the markdown file
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-68 January 28, 2022 00:01 Inactive
@coreyhunt
Updates the images
f7faa16 
This adds the images by dragging and dropping them instead of referencing them from a directory. This also uses tables as placeholders for a do/don't component.
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-68 January 28, 2022 01:28 Inactive
@coreyhunt coreyhunt requested a review from joni-f-g January 28, 2022 01:29
joni-f-g
joni-f-g suggested changes Jan 28, 2022
View reviewed changes
Copy link

@joni-f-g joni-f-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! just a few suggestions/questions, lmk if you want to discuss

@joni-f-g joni-f-g self-requested a review January 28, 2022 21:46
@coreyhunt
Updates to address comments
806631e 
Makes updates to the documentation based on feedback from @JacksonGonzales .
- Fixes the image's classes
- Adds some frontmatter info
- Restructures the headers a bit to remove the need for an h6
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-68 February 2, 2022 20:15 Inactive
@coreyhunt
Copy link
Contributor Author

coreyhunt commented Feb 2, 2022 •
edited
Loading

@JacksonGonzales , the images still look too wide even with the changes to the classes.
It was caching or something. It looks better now.

@coreyhunt coreyhunt merged commit d7fb610 into main Feb 10, 2022
@coreyhunt coreyhunt deleted the coreyhunt-icon-docs branch February 10, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joni-f-g joni-f-g joni-f-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coreyhunt @joni-f-g @shawnbot