Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create fields-and-forms.md #81

Merged
merged 10 commits into from
Mar 17, 2022
Merged

Create fields-and-forms.md #81

merged 10 commits into from
Mar 17, 2022

Conversation

coreyhunt
Copy link
Contributor

@coreyhunt coreyhunt commented Mar 15, 2022 •
edited by shawnbot
Loading

Creates the top-level, general field documentation

👀 Preview link

@coreyhunt coreyhunt requested a review from shawnbot March 15, 2022 00:26
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-81 March 15, 2022 00:26 Inactive
@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

Size Change: 0 B

Total Size: 123 kB

ℹ️ View Unchanged
Filename Size
dist/css/base.css 266 B
dist/css/components.css 875 B
dist/css/docs.css 1.34 kB
dist/css/fonts.css 169 B
dist/css/overrides.css 104 B
dist/css/sfds.css 45.4 kB
dist/css/typography.css 557 B
dist/css/utilities.css 44 kB
dist/js/docs.js 13.9 kB
dist/js/icons.js 8.29 kB
dist/js/sfds.js 8.29 kB

compressed-size-action

shawnbot
shawnbot reviewed Mar 15, 2022
View reviewed changes
Copy link
Member

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is off to a great start, thank you! I made some copy suggestions before asking you whether @AnitaYCheng had already reviewed this 🙈. Feel free to accept, reject, or edit any of them and re-request a review. I'm sorry if this is too pedantic 😬

@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-81 March 15, 2022 19:51 Inactive
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-81 March 15, 2022 19:52 Inactive
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-81 March 15, 2022 19:52 Inactive
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-81 March 15, 2022 19:57 Inactive
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-81 March 15, 2022 19:58 Inactive
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-81 March 16, 2022 16:44 Inactive
@shawnbot shawnbot temporarily deployed to sfgov-design-system-pr-81 March 16, 2022 17:39 Inactive
@coreyhunt coreyhunt requested a review from shawnbot March 16, 2022 21:35
@coreyhunt
Copy link
Contributor Author

I merged the suggestions with a few tweaks. Thanks for the suggestions @shawnbot

@coreyhunt coreyhunt enabled auto-merge March 17, 2022 21:59
shawnbot
shawnbot approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@coreyhunt coreyhunt merged commit 8659cf2 into main Mar 17, 2022
@coreyhunt coreyhunt deleted the coreyhunt-adds-forms-field-general branch March 17, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coreyhunt @shawnbot