Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:added footer feature #56

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Conversation

jkim906
Copy link
Contributor

@jkim906 jkim906 commented Sep 28, 2024

Context

This pull request addresses issue #55 -implemented a footer at the bottom of the website that includes copyright information and social media links with a background matching the colour scheme of hex colour: 333.

Closes #55

What Changed?

  • when scrolling to the bottom of the page there will be dark shaded footer with links to social media and information regarding our copyright information.

How To Review

Test by:

  1. npm install
  2. start running the server

Testing

I ran the server using npm start and scrolled to the bottom. I clicked on every link. Currently, only the GitHub logo takes us to our GitHub Repo as the others are currently just placeholders.

Risks

NA

Notes

NA

Copy link
Contributor

@today0-o today0-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have cloned your branch and checked that the footer works fine! It adds a good source of navigation for our web app so I'm sure it is quiet helpful for the users.

Future implementation could be making our social account, and actually connecting them to the footer links so that the users can access our social accounts so they can interact, send feedback and contribute to your project! LGTM to merge.

@today0-o today0-o merged commit 3f2434a into SOFTENG310-G5:main Sep 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Implement Footer
2 participants