Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feat/refactor components" #59

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

syoo881
Copy link
Contributor

@syoo881 syoo881 commented Sep 30, 2024

Reverts #58

Why was this Reverted?

  • Upon running the codebase, there was a critical bug that slipped through production.
  • This bug was hard to debug, as it did occur 100% of the time, thus slipping through the PR check.
  • Reverting these changes to refactoring is more straightforward and easier than finding a bug, therefore we as a collective team decided to undo this pull request.

What Next?

  • The refactoring components was something important that had to be done.
    Therefore, we will refactor the components again, but this time making sure to address any bugs in between.

Pull Request assigned to main developers of the backend component, and the refactoring

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@tyin363 tyin363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the revert, Seth. I'll take care of refactoring the components in another PR, ensuring that the bugs are addressed properly this time. Appreciate the team's quick action on this!

@tyin363 tyin363 merged commit 3a7b086 into main Sep 30, 2024
7 of 8 checks passed
@tyin363 tyin363 deleted the revert-58-feat/refactor-components branch September 30, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants