feat: Limited the display of the overall leaderboard to the top 5 only #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syoo881
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
A simple, yet crucial change!
Using a slice method to limiting the display of the overall leaderboard works effectively, and I see no big issues upon testing.
I will say though, there might be an alternative we can consider and discuss with our team:
Alternative
- Possibly, instead of setting a hard limit to 5, we could have a box with all the top scores possibly up to 10~15, and have them just be scrollable.
This pull request was made to address the issue of the leaderboard filling up the whole bottom portion of the page, but a scrollable box could be something to consider.
But otherwise, Good Job Rusiru! Looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #60
What Changed?
I limited the size of the leaderboard to only be 5 rows of data.
How To Review
Start the application including the backend and frontend and look at the homepage to see if the leaderboard displayed contains only 5 rows of user data.
Testing
I have created additional users to ensure none are added to the leaderboard.
Risks
NA
Notes
If an error occurs on start up saying " Module not found error can't resolve 'mdb-react-ui-kit' " ensure to do npm install in the frontend folder This is due to the footer commit.