Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/refactor: Update Chimp Popup #85

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

syoo881
Copy link
Contributor

@syoo881 syoo881 commented Oct 7, 2024

Updated Chimp game popup to include the current score, and look more appealing. Also rearranged the files within backend directory, to ensure that the backend directory is spelt "backend", not "Backend"

Context

Closes #84

What Changed?

  • Updated ChimpTest popup, by changing the styling in ChimpTest.css, and addding a score counter within the ChimpTest.js
  • Also, renamed the Backend folder to be "backend", not "Backend" to provide consistency across naming in the folders and files.

How To Review

  • Take a look at the ChimpTest.css and ChimpTest.js to make sure everything else other than the intended popup is changed.
  • Try to run the ChimpTest, and see if the popup shows as intended. Make sure that the backend information correctly updates.
  • Double check if the backend folder is named "backend" with a lowercase b

Testing

  • Tried playing multiple rounds of the ChimpTest, alongside submitting backend information.
    From my end, everything worked as intended.

Risks

  • There is a chance that the popup may have changed information that is to be submitted to the backend. However, I don't believe this is the case, and I did not change anything in terms of objects to be submitted.

Notes

N/A

Updated Chimp game popup to include the current score, and look more appealing.
Also rearranged the files within backend directory, to ensure that the backend directory is spelt "backend", not "Backend"
Copy link
Contributor

@jkim906 jkim906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me. thanks for the refactor and feature of the pop up. The pop up looks nicer now and looks ready to merge onto the main branch

@jkim906 jkim906 merged commit 8a305bf into SOFTENG310-G5:main Oct 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Update popup in Chimp Game to be more visually appealing
2 participants