Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eda): filter by column #1217

Merged
merged 67 commits into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
403cc25
fix: profiling scrollbar
SmiteDeluxe Jun 18, 2024
eac6deb
feat: show history
SmiteDeluxe Jun 18, 2024
00967de
fix: reorder history and holding still
SmiteDeluxe Jun 18, 2024
2de5205
feat: basic history with undones (no redones yet)
SmiteDeluxe Jun 18, 2024
53c06c5
fix: history bugs & keep profiling open
SmiteDeluxe Jun 20, 2024
6eeeb28
fix: history tab order & cancel to remove entry
SmiteDeluxe Jun 20, 2024
9307148
feat: redo history & fix: a lot of history stuff & UX
SmiteDeluxe Jun 20, 2024
17983b5
refactor: linter issues
SmiteDeluxe Jun 20, 2024
a28aaf1
fix: reset lastFocusedTab in deploy
SmiteDeluxe Jun 20, 2024
6a1b691
Merge branch '1211-eda-history-basic-setup' into 1180-eda-table-right…
SmiteDeluxe Jun 21, 2024
8455bc4
feat: submenu & hide from selection
SmiteDeluxe Jun 21, 2024
12e9503
fix: only allowed plots for non numerical
SmiteDeluxe Jun 21, 2024
2a2bd6f
feat: tootips explaining not possible actions
SmiteDeluxe Jun 21, 2024
75e6215
feat: cell right click for selections
SmiteDeluxe Jun 21, 2024
fa38be2
fix: context menu styling
SmiteDeluxe Jun 21, 2024
d765181
fix: undoing last history entry prevents delayed results f taking effect
SmiteDeluxe Jun 21, 2024
f7fd327
Merge branch '1211-eda-history-basic-setup' into 1180-eda-table-right…
SmiteDeluxe Jun 21, 2024
25af8ef
fix: context menu formatting
SmiteDeluxe Jun 21, 2024
3c2c8d6
refactor: megalinter
SmiteDeluxe Jun 21, 2024
afeec53
fix: plot possibilities also shown if wrong selected count with explain
SmiteDeluxe Jun 21, 2024
92713cf
Merge branch '1180-eda-table-right-click-improvements' into 1214-eda-…
SmiteDeluxe Jun 21, 2024
dde7d4e
feat: refresh outdated tab
SmiteDeluxe Jun 21, 2024
7170587
fix: if undone new tab not in view anyway, don't change focus
SmiteDeluxe Jun 21, 2024
3e1006c
Merge branch '1211-eda-history-basic-setup' into 1180-eda-table-right…
SmiteDeluxe Jun 21, 2024
c540fd8
Merge branch '1180-eda-table-right-click-improvements' into 1214-eda-…
SmiteDeluxe Jun 21, 2024
9c2430f
Merge branch '1214-eda-refresh-outdated-view' into 1216-eda-filter-by…
SmiteDeluxe Jun 21, 2024
e5af5f7
fix: possible column filters now not from profiling
SmiteDeluxe Jun 21, 2024
6a52851
feat: basic filters
SmiteDeluxe Jun 21, 2024
abc9869
feat: remove filter & feat: bigger hitboxes
SmiteDeluxe Jun 21, 2024
b4b7127
feat: remove filters
SmiteDeluxe Jun 21, 2024
868e780
feat: outdate views on filtering
SmiteDeluxe Jun 21, 2024
8e5f8e4
fix: undo always switch to vis of undo action if possible
SmiteDeluxe Jun 21, 2024
625bbf6
Merge branch '1211-eda-history-basic-setup' into 1180-eda-table-right…
SmiteDeluxe Jun 21, 2024
cb96e67
Merge branch '1180-eda-table-right-click-improvements' into 1214-eda-…
SmiteDeluxe Jun 21, 2024
9f4ec79
Merge branch '1214-eda-refresh-outdated-view' into 1216-eda-filter-by…
SmiteDeluxe Jun 21, 2024
ff2cb02
feat: refresh profiling if outdated
SmiteDeluxe Jun 22, 2024
3ac6650
refactor: linter
SmiteDeluxe Jun 22, 2024
72a4371
Merge branch '1214-eda-refresh-outdated-view' into 1216-eda-filter-by…
SmiteDeluxe Jun 22, 2024
6839ae9
refactor: linter
SmiteDeluxe Jun 22, 2024
2939e45
fix: profilingState not just there again (broken) after new entry
SmiteDeluxe Jun 22, 2024
1261d66
fix: bugs history & linter
SmiteDeluxe Jun 22, 2024
c6d46cd
fix: issue of profiling being always generated for last state
SmiteDeluxe Jun 22, 2024
492f989
Merge branch 'main' into 1180-eda-table-right-click-improvements
lars-reimann Jun 24, 2024
3f33fa6
Merge branch 'main' into 1214-eda-refresh-outdated-view
lars-reimann Jun 24, 2024
5bcd7e4
fix: column right click on first column
SmiteDeluxe Jun 24, 2024
0dfa2ad
Merge branch '1180-eda-table-right-click-improvements' into 1216-eda-…
SmiteDeluxe Jun 24, 2024
5eadbf4
Merge remote-tracking branch 'origin/1214-eda-refresh-outdated-view' …
SmiteDeluxe Jun 24, 2024
7f6c710
fix: history reverse & current focused
SmiteDeluxe Jun 24, 2024
3c09513
fix: profiling refresh to update also valid past and future entries
SmiteDeluxe Jun 24, 2024
f30fe84
Merge remote-tracking branch 'origin/main' into 1214-eda-refresh-outd…
SmiteDeluxe Jun 24, 2024
dca749a
Merge branch '1214-eda-refresh-outdated-view' into 1216-eda-filter-by…
SmiteDeluxe Jun 24, 2024
d91a4e2
style: apply automated linter fixes
megalinter-bot Jun 24, 2024
8520c07
fix: sort specific values in filter
SmiteDeluxe Jun 24, 2024
3e3ddb6
Merge remote-tracking branch 'origin/1216-eda-filter-by-column' into …
SmiteDeluxe Jun 24, 2024
db9b5e1
fix: history shortcuts
SmiteDeluxe Jun 24, 2024
b7e1ad6
feat: outdated reasons on hover
SmiteDeluxe Jun 26, 2024
33ed1a9
fix
SmiteDeluxe Jun 26, 2024
15af310
fix: unused imports
SmiteDeluxe Jun 26, 2024
c4d5fd9
fix: filters outdate all plots
SmiteDeluxe Jun 26, 2024
40ef04f
fix: tab no outdated text and bigger plot width
SmiteDeluxe Jun 26, 2024
96206fe
Merge branch 'main' into 1216-eda-filter-by-column
lars-reimann Jun 29, 2024
f7d3cc2
fix: colors & small bug
SmiteDeluxe Jul 10, 2024
d3d306f
Merge remote-tracking branch 'origin/1216-eda-filter-by-column' into …
SmiteDeluxe Jul 10, 2024
c219041
fix: final fixes
SmiteDeluxe Sep 15, 2024
d985117
Merge branch 'main' into 1216-eda-filter-by-column
SmiteDeluxe Sep 15, 2024
e52b76c
Merge branch 'main' into 1216-eda-filter-by-column
lars-reimann Sep 25, 2024
22f3f5e
build: update ESLint config
lars-reimann Sep 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 39 additions & 31 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"docs:api": "shx rm -rf dist docs/api && safe-ds document packages/safe-ds-lang/src/resources/builtins -o docs/api"
},
"devDependencies": {
"@lars-reimann/eslint-config-svelte": "^7.3.0",
"@lars-reimann/eslint-config-svelte": "^7.4.0",
"@lars-reimann/prettier-config-svelte": "^5.2.1",
"@semantic-release/changelog": "^6.0.3",
"@semantic-release/exec": "^6.0.3",
Expand Down
4 changes: 2 additions & 2 deletions packages/safe-ds-eda/src/App.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import TableView from './components/TableView.svelte';
import Sidebar from './components/Sidebar.svelte';
import { throttle } from 'lodash';
import { currentTabIndex, tableKey, tabs } from './webviewState';
import { currentTabIndex, tabKey, tableKey, tabs } from './webviewState';
import TabContent from './components/tabs/TabContent.svelte';

let sidebarWidth = 307; // Initial width of the sidebar in pixels
Expand Down Expand Up @@ -49,7 +49,7 @@
<TableView {sidebarWidth} />
{/key}
</div>
{#key $tableKey}
{#key $tabKey}
{#if $tabs.length > 0}
{#each $tabs as tab, index}
<div class:hide={index !== $currentTabIndex}>
Expand Down
16 changes: 14 additions & 2 deletions packages/safe-ds-eda/src/apis/extensionApi.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { get } from 'svelte/store';
import type { HistoryEntry } from '../../types/state';
import { table } from '../webviewState';
import { profilingLoading, table, history } from '../webviewState';
import type { ExecuteRunnerAllEntry } from '../../types/messaging';
import { filterHistoryOnlyInternal } from './historyApi';
import { filterHistoryOnlyInternal } from '../filterHistory';

export const createInfoToast = function (message: string) {
window.injVscode.postMessage({ command: 'setInfo', value: message });
Expand Down Expand Up @@ -102,3 +102,15 @@ export const executeRunner = function (state: HistoryEntry[], entry: HistoryEntr
executeRunnerDefault(state, entry);
}
};

export const refreshProfiling = function (historyId: number) {
profilingLoading.set(true);

window.injVscode.postMessage({
command: 'refreshProfiling',
value: {
historyEntries: get(history).slice(0, historyId + 1),
historyId,
},
});
};
Loading
Loading