Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error code return feature. Version up to v1.10.6 #678

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Feb 16, 2025

Description

Please include a summary of the change and which is fixed.

  • Add --error argument to produce failure with using in pre-commit
  • Add --stdout argument to disable the default output when necessary
  • Documents and other small fixes
  • Version up to v1.10.6

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.52%. Comparing base (ff602e0) to head (d59ecfe).

Files with missing lines Patch % Lines
credsweeper/__main__.py 81.81% 2 Missing ⚠️
credsweeper/credentials/credential_manager.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
- Coverage   92.71%   92.52%   -0.20%     
==========================================
  Files         137      137              
  Lines        5025     5043      +18     
  Branches      823      826       +3     
==========================================
+ Hits         4659     4666       +7     
- Misses        220      229       +9     
- Partials      146      148       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek marked this pull request as ready for review February 17, 2025 05:21
@babenek babenek requested a review from a team as a code owner February 17, 2025 05:21
@xDizzix xDizzix self-requested a review February 17, 2025 12:19
@babenek babenek merged commit aafc50e into Samsung:main Feb 17, 2025
29 checks passed
@babenek babenek deleted the stdout branch February 17, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants