-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more types of shapes with diff-updates #29
Conversation
…ove `mapOptions.markers` as an option for markers.
…OP animations would run every time
@SamvelRaja would love to hear your thoughts on this. :) |
@erkie kindly merge it on your own and let me know. please make sure the tests are passing :p |
Thanks @SamvelRaja. Tests pass now! Merging |
Add more types of shapes with diff-updates
@erkie will update npm by this week end. |
Cool! My npm email is [email protected] |
@erkie i tried adding as you as collabarator in npm to allow you to publish by yourself, but i couldn't get your username for it. |
My npm username is erikrothoff if it helps. Thanks! |
Added you as collaborator, should be reflected within 24hrs from now |
@SamvelRaja this is in reference to the issue where we discussed marker diffing #27.
This includes some major changes in the API of the component.
markerOptions
object andinfoWindow
object into separate propertiesmarkerOptions
to justmarkers
Helper
-mega object into smaller classes, and to be used as an instance insteadrectangles
,circles
shapes as wellkey
attributes mandatory on all passed in objects, so we can diff and add new ones, update old ones and remove removed onesExample usage is now for example:
With this comes a lot of flexibility and the ability to easily add more objects, like Polygons and PolyLines. We can also add a lot more lifetime callbacks to the objects, like
onCreate
,onUpdate
andonRemove
which provides loads of flexibility. We can also animate changes because we always only update changed attributes.What do you think? I have tried it out in our projects and it works very well and is nice to work with.