Allows assign_new/2 to take a map of values
#293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistency in the API is essential in line with the recent work of `assign/2` taking a list or map. Building on the previous work allows `assign_new/2` to work with either a keyword list or map. The change is applied to `Driver` and `Scene` so both have a consistent API. Thanks to @amclain and @thejohncotton for the inspiration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Building on the previous work allows
assign_new/2to work with either a keyword list or map.The change is applied to
DriverandSceneso both have a consistent API.Motivation and Context
Consistency in the API is essential in line with the recent work of
assign/2taking a list or map.Thanks to @amclain and @thejohncotton for the inspiration.
Types of changes
not work as expected)
but make things better)
Checklist