Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Newton with finite diff #13

Merged
merged 1 commit into from
Nov 22, 2020
Merged

Fix Newton with finite diff #13

merged 1 commit into from
Nov 22, 2020

Conversation

YingboMa
Copy link
Member

Fix #12

@ChrisRackauckas
Copy link
Member

This is still non-allocating?

@YingboMa
Copy link
Member Author

YingboMa commented Nov 22, 2020 •
edited
Loading

FiniteDiff allocates.

julia> @ballocated solve(NonlinearProblem{false}($f, $u0), NewtonRaphson(;autodiff=false))
12384

julia> @ballocated solve(NonlinearProblem{false}($f, $u0), NewtonRaphson())
0

@YingboMa YingboMa merged commit 1098b35 into master Nov 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the myb/fix branch November 22, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jacobian erroneously calls finite_difference_derivative
2 participants
@YingboMa @ChrisRackauckas