Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add joss paper #124

Merged
merged 13 commits into from
Apr 4, 2023
Merged

add joss paper #124

merged 13 commits into from
Apr 4, 2023

Conversation

paulflang
Copy link
Member

No description provided.

Comment on lines +47 to +49
preprocessing to analyze and enhance the model. ModelingToolkit can automatically
generate fast functions for model components, along with automatically sparsifying
and parallelizing the computations. This enabled highly performing solvers of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe composition should be mentioned? Though we haven't actually used it with SBML

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't think SBML is well suited for that. It is too often that the semantics of species in two different SBML models differs slightly (different isoform, complex composition, posttranslational modification), even if the models are for the same cell type to begin with.

paulflang and others added 2 commits March 21, 2023 21:25
Co-authored-by: Christopher Rackauckas <[email protected]>
Co-authored-by: Christopher Rackauckas <[email protected]>
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #124 (8dc347b) into main (7117974) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   89.10%   89.10%           
=======================================
  Files           6        6           
  Lines         312      312           
=======================================
  Hits          278      278           
  Misses         34       34           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulflang
Copy link
Member Author

Hi @ChrisRackauckas and @anandijain . I am attaching the compiled PDF for the paper. Let me know if you are happy with it. @anandijain : do you have an orcid I should add?
paper.pdf

@paulflang paulflang marked this pull request as ready for review March 23, 2023 00:49
@paulflang paulflang requested a review from anandijain March 23, 2023 00:49
@ChrisRackauckas
Copy link
Member

I think this looks good to go. CI is failing on v1.6 though? 😅

@paulflang
Copy link
Member Author

@ChrisRackauckas or @anandijain : Do you have an idea where the LoadError: Cert verify failed: BADCERT_EXPIRED while requesting in the CI is coming from?

@ChrisRackauckas
Copy link
Member

I don't know what that is, maybe @thazhemadam might.

@paulflang paulflang merged commit 1aa5a36 into main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants