Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add godot3 and godot3-mono, remove godot4{-mono} as it's now in extras #1061

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

Calinou
Copy link
Contributor

@Calinou Calinou commented Mar 5, 2023

Manifests were copied from the extras bucket from the commit before they were updated to Godot 4.

godot and godot-mono can be installed from the extras bucket if you need Godot 4.

@idbrii
Copy link

idbrii commented Dec 29, 2023

I would suggest keeping godot4 and godot4-mono.

The Versions bucket has python312 even though python 3.12 can be installed from the Main bucket. Similarly, people can install extras' godot to stay on latest or use godot3/godot4 from Versions to stick on a specific major version.

It also prevents failed upgrades if someone had installed godot4 and then tries to upgrade it to the latest 4.x release.

However, godot4 is still pointing at rc6, so fewer manifests to maintain is a good reason to remove it.

@idbrii
Copy link

idbrii commented Dec 29, 2023

I gave this a spin and (after updating hash and version to 3.5.3) installed godot3-mono.

However, checkver is incorrect. https://github.com/godotengine/godot/releases/latest will only show one release and it'll probably be a 4.x one.

I think instead it needs to point at the full release list and hard code 3 in the version.

I think this should work:

    "checkver": {
        "url": "https://api.github.com/repos/godotengine/godot/releases",
        "jsonpath": "$[*].tag_name",
        "regex": "(3.[\\d.]+)-stable"
    },

I used jsonpath expression tester to test the query and regex101 to test the regex on those results (but without escaping \). It matched 3.5.3.

Failing that, this will probably scrape the html correctly:

    "checkver": {
        "url": "https://github.com/godotengine/godot/releases",
        "regex": "(3.[\\d.]+)-stable"
    },

Alternatively, it could point at the 3.x download page: https://godotengine.org/download/3.x/windows/

@niheaven niheaven merged commit 521b38c into ScoopInstaller:master Feb 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Add godot3 and godot3-mono
3 participants