-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulcast #2
base: master
Are you sure you want to change the base?
Conversation
5ab24b7
to
3300d5f
Compare
How can we test this? I downloaded latest build from artifacts but I don't see any new option on OBS? A little help? :) |
5f24f56
to
16d2f99
Compare
Tested with Broadcast Box - works great! This is very cool indeed. |
Nice! 🥇 |
Hey @Sean-Der thanks for your great work! I am running the Arm MacOs OBS version and can successfully stream with simulcast enabled to the website. At least that is what I think is happening as all the metrics look good in OBS. On the website I also get the simulcast controls but unfortunately the stream does not load whether I use Safari or Chromium as a browser. What is the best way to debug this further and provide feedback? |
e99b4c3
to
ed6dcb6
Compare
Sorry about that @SetoKaiba @chhofi What encoder are using? Can you try these settings? Does it help if you lower the bitrate? Does it work without Simulcast enabled? |
Hi, @Sean-Der . And then I tried it with my local ZLMediaKit server. It's working with OBS WHIP before. It supports simulcast. And here's the warning I saw from ZLMediaKit logs for simulcast branch.
"未识别的sr rtcp包" means "unrecognized sr rtcp packet".
|
@SetoKaiba can you try running https://github.com/glimesh/broadcast-box locally? Just to debug
|
@Sean-Der I tried with broadcast-box Another small question, I run it with docker in windows. The video is not loaded. But the streaming doesn't report any error. For ZLMediaKit, I'll try to debug the problem with ZLMediaKit's maintainers. But the ZLMediaKit is working with simulcast. Its demo page run successfully. So it seems to be a compatiblity problem. Thank you. |
@SetoKaiba thanks for all the testing! My guess is that we aren't implementing something properly? If you can figure out what ZLMediaKit is looking for I can implement that right away! |
1c30590
to
38124b5
Compare
eabfe74
to
5e60202
Compare
03eb4a5
to
6a1907b
Compare
010134b
to
f35d3e7
Compare
4fab92b
to
847ad6d
Compare
be19187
to
26340d7
Compare
6981fcc
to
af06f9b
Compare
Add WebRTC Simulcast Support