-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional Cargo test --workspace
#77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
integration.rs
tests are ran after the the reth binary are brought upMade a minor change for
Fixed backup datadir bug. This was causing failure with inconsistent datadir recognized by the Backup handle (which was instantiated in TreeConfig) vs the real Datadir from LaunchContext
Update seismic.yml to use the updated set of test
update the sync_to time to 30s upperbound from the orginal 10s. The current time it takes for e2e_test_send_transaction is 17s on large runner
upgrate seismic.yml to use cargo nextest to increase test speed
These tests still fail if you run on upstream reth locally on mac against this commit so not sure how they succeed in github actions. We ignore them in
.config/nextest.toml
eth::core::tests::* --exact --show-output
to reproducecargo test --package reth-rpc --lib --all-features -- eth::core::tests --exact --show-output
This failure is due to the fact that
BaseFeeParams
calculatesnext_block_base_fee
differently fromBaseFeeParams
. See temporary fix here commitproviders::static_file::tests::test_header_truncation
andproviders::static_file::tests::test_tx_based_truncation
to reproducecargo test --package reth-rpc --lib --all-features -- providers::static_file::tests::test_header_truncation
Example run can also be seen here run