Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional Cargo test --workspace #77

Merged
merged 43 commits into from
Feb 7, 2025
Merged

Functional Cargo test --workspace #77

merged 43 commits into from
Feb 7, 2025

Conversation

phexyz
Copy link
Collaborator

@phexyz phexyz commented Feb 6, 2025

  1. In integration.rs tests are ran after the the reth binary are brought up

  2. Made a minor change for

  3. Fixed backup datadir bug. This was causing failure with inconsistent datadir recognized by the Backup handle (which was instantiated in TreeConfig) vs the real Datadir from LaunchContext

  4. Update seismic.yml to use the updated set of test

  5. update the sync_to time to 30s upperbound from the orginal 10s. The current time it takes for e2e_test_send_transaction is 17s on large runner

  6. upgrate seismic.yml to use cargo nextest to increase test speed

  7. These tests still fail if you run on upstream reth locally on mac against this commit so not sure how they succeed in github actions. We ignore them in .config/nextest.toml

eth::core::tests::* --exact --show-output to reproduce
cargo test --package reth-rpc --lib --all-features -- eth::core::tests --exact --show-output

This failure is due to the fact that BaseFeeParams calculates next_block_base_fee differently from BaseFeeParams. See temporary fix here commit

providers::static_file::tests::test_header_truncation and providers::static_file::tests::test_tx_based_truncation to reproduce
cargo test --package reth-rpc --lib --all-features -- providers::static_file::tests::test_header_truncation

Example run can also be seen here run

@phexyz phexyz changed the title Fixing Cargo test --workspace Fixed Cargo test --workspace Feb 7, 2025
@phexyz phexyz merged commit b49a401 into seismic Feb 7, 2025
5 checks passed
@phexyz phexyz deleted the peter/fix-make-test branch February 7, 2025 21:04
@phexyz phexyz changed the title Fixed Cargo test --workspace Functional Cargo test --workspace Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant