-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Add nullability annotations to print types #14773
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Thanks @RenderMichael, safe to merge (if CI is green), after release process of 4.27 is finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix one comment.
Thanks! I saw the recent 4.27 release; it was nice to see the .NET release notes section longer than previous releases. |
The changes are not related to failed CI tests (ShadowRoot). Merging it. |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
This adds nullability annotations to the PDF-print stack, as well as documenting potential exceptions alongside some code modernization.
Motivation and Context
Contributes to #14640
Types of changes
Checklist
PR Type
Enhancement, Bug fix, Tests
Description
PrintOptions
.Changes walkthrough 📝
EncodedFile.cs
Add nullability and refactor EncodedFile class
dotnet/src/webdriver/EncodedFile.cs
ToString
method.ISupportsPrint.cs
Add nullability and exception documentation to ISupportsPrint
dotnet/src/webdriver/ISupportsPrint.cs
Print
method.PrintDocument.cs
Enhance PrintDocument with nullability and exceptions
dotnet/src/webdriver/PrintDocument.cs
SaveAsFile
method.PrintOptions.cs
Improve PrintOptions with nullability and validation
dotnet/src/webdriver/PrintOptions.cs
Screenshot.cs
Add nullability and exceptions to Screenshot class
dotnet/src/webdriver/Screenshot.cs
WebDriver.cs
Add null check in WebDriver Print method
dotnet/src/webdriver/WebDriver.cs
printOptions
inPrint
method.PrintTest.cs
Add validation tests for PrintOptions
dotnet/test/common/PrintTest.cs