Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop editions command #1204

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Drop editions command #1204

merged 5 commits into from
Jan 25, 2023

Conversation

gonzaloriestra
Copy link
Contributor

WHY are these changes introduced?

I guess it's time to remove the hidden command created for Editions Summer 2022.

WHAT is this pull request doing?

Removes the command

How to test your changes?

pnpm shopify editions doesn't work anymore

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/theme-developer-tools
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023

Benchmark report

The following table contains a summary of the startup time for all commands.

Status Command Baseline (avg) Current (avg) Diff
🟢 app build 919.33 ms 904.67 ms -1.6 %
🟢 app deploy 1208.67 ms 1216 ms 0.61 %
🟢 app dev 1197 ms 1213.33 ms 1.36 %
🟢 app env pull 1116.33 ms 1118 ms 0.15 %
🟢 app env show 1103.33 ms 1112.67 ms 0.85 %
🟢 app generate extension 1156.33 ms 1162.33 ms 0.52 %
🟢 app generate schema 1130.33 ms 1137 ms 0.59 %
🟢 app info 1111.33 ms 1116.67 ms 0.48 %
🟢 app scaffold extension 1162.67 ms 1169 ms 0.54 %
🟢 app update-url 1126.33 ms 1087.33 ms -3.46 %
🟢 theme check 848.33 ms 859.67 ms 1.34 %
🟢 theme delete 1057.33 ms 1067.33 ms 0.95 %
🟢 theme dev 1045.33 ms 1054.67 ms 0.89 %
🟢 theme help-old 853.67 ms 864.33 ms 1.25 %
🟢 theme info 902.67 ms 904 ms 0.15 %
🟢 theme init 962.33 ms 969.67 ms 0.76 %
🟢 theme language-server 845.33 ms 866 ms 2.44 %
🟢 theme list 1055 ms 1055.67 ms 0.06 %
🟢 theme open 1065 ms 1057 ms -0.75 %
🟢 theme package 851.67 ms 853.67 ms 0.23 %
🟢 theme publish 1057 ms 1075.33 ms 1.73 %
🟢 theme pull 1047 ms 1052 ms 0.48 %
🟢 theme push 1058.33 ms 1052.33 ms -0.57 %
🟢 theme share 1037.67 ms 1061.67 ms 2.31 %
🟢 webhook trigger 1061.33 ms 1055 ms -0.6 %

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
70.96% (-0.09% 🔻)
3734/5262
🟡 Branches 67.85% 1638/2414
🟡 Functions
69.41% (-0.09% 🔻)
969/1396
🟡 Lines
72.06% (-0.09% 🔻)
3559/4939

Test suite run success

945 tests passing in 483 suites.

Report generated by 🧪jest coverage report action from dc0c7be

@gonzaloriestra gonzaloriestra marked this pull request as ready for review January 24, 2023 22:56
@gonzaloriestra gonzaloriestra requested review from a team, pepicrft and amcaplan and removed request for a team January 24, 2023 22:57
@gonzaloriestra gonzaloriestra merged commit 67aa11e into main Jan 25, 2023
@gonzaloriestra gonzaloriestra deleted the drop-editions-command branch January 25, 2023 10:55
@shopify-shipit shopify-shipit bot temporarily deployed to nightly January 26, 2023 09:16 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production January 26, 2023 17:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants