Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clear mutation #2353

Merged
merged 2 commits into from
Jul 6, 2023
Merged

add clear mutation #2353

merged 2 commits into from
Jul 6, 2023

Conversation

ryancbahan
Copy link
Contributor

@ryancbahan ryancbahan commented Jul 5, 2023

Adds clear mutation for scopes for the serverless install functionality.

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/theme-code-tools
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@ryancbahan ryancbahan marked this pull request as ready for review July 5, 2023 20:04
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.48% (-0.04% 🔻)
5381/7323
🟡 Branches
70.21% (-0.02% 🔻)
2545/3625
🟡 Functions
72.24% (-0.07% 🔻)
1392/1927
🟡 Lines
75.16% (-0.04% 🔻)
5117/6808
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / clear_requested_scopes.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / loader.ts
87.68% (-0.06% 🔻)
73.03%
94.92% (-0.08% 🔻)
88.36% (-0.06% 🔻)
🟢
... / link.ts
97.14% (-0.36% 🔻)
94.12% (+2.81% 🔼)
100%
97.14% (-0.36% 🔻)
🟢
... / push.ts
80% (-8.46% 🔻)
90% (-2.31% 🔻)
60% (-15% 🔻)
85.19% (-6.48% 🔻)

Test suite run success

1253 tests passing in 625 suites.

Report generated by 🧪jest coverage report action from 68b43b5

@ryancbahan ryancbahan added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit b6ad0c8 Jul 6, 2023
@ryancbahan ryancbahan deleted the update-push branch July 6, 2023 16:52
@shopify-shipit shopify-shipit bot temporarily deployed to nightly July 7, 2023 15:00 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production July 26, 2023 11:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants