Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show intro line on first used prompt during app create #2357

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

amcaplan
Copy link
Contributor

@amcaplan amcaplan commented Jul 6, 2023

WHY are these changes introduced?

We shouldn't show Let’s get started by naming your app project. if we're not going to prompt them for a name.

WHAT is this pull request doing?

Before:

$ npm init @shopify/app --name somename

Welcome. Let’s get started by naming your app project. You can change it later.

?  Which template would you like to use?

>  (1) node
   (2) php
   (3) ruby
   (4) none (build an app with extensions only)

   Press ↑↓ arrows to select, enter to confirm.

After:

$ npm init @shopify/app --name somename

Welcome. Let’s get started by choosing a template for your app project.

?  Which template would you like to use?

>  (1) node
   (2) php
   (3) ruby
   (4) none (build an app with extensions only)

   Press ↑↓ arrows to select, enter to confirm.

How to test your changes?

dev create-app with and without --name

You can also run bin/ create-test-app.js for another example of why this is irritating.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@amcaplan amcaplan force-pushed the remove-intro-line-when-no-prompt branch from 5419c4a to 309393b Compare July 6, 2023 11:36
@@ -57,6 +59,10 @@ const init = async (options: InitOptions): Promise<InitOutput> => {
}

if (!template) {
if (!welcomed) {
renderText({text: '\nWelcome. Let’s get started by choosing a template for your app project.'})
welcomed = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't strictly necessary, but good for preventing bugs in case we add more prompts (which hopefully we never will).

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.53% (-0.02% 🔻)
5385/7324
🟡 Branches
70.22% (-0.09% 🔻)
2547/3627
🟡 Functions
72.3% (-0.01% 🔻)
1394/1928
🟡 Lines
75.2% (-0.03% 🔻)
5121/6810
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / loader.ts
87.75% (-0.66% 🔻)
73.03% (-1.69% 🔻)
95% (-0.08% 🔻)
88.42% (-0.7% 🔻)
🟢
... / link.ts
97.5%
91.3% (-3.93% 🔻)
100% 97.5%
🟢
... / identifiers-extensions.ts
98.28%
87.88% (-3.03% 🔻)
100%
98.04% (-0.04% 🔻)
🟢
... / identifiers-functions.ts
95.45%
64.29% (-7.14% 🔻)
100% 100%

Test suite run success

1254 tests passing in 625 suites.

Report generated by 🧪jest coverage report action from 309393b

@amcaplan amcaplan added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit 3a6715d Jul 6, 2023
@amcaplan amcaplan deleted the remove-intro-line-when-no-prompt branch July 6, 2023 12:22
@shopify-shipit shopify-shipit bot temporarily deployed to nightly July 6, 2023 14:56 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production July 26, 2023 11:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants