Skip to content

Commit

Permalink
Refactor to resolve ts-expect-error comment (#1418)
Browse files Browse the repository at this point in the history
Co-authored-by: Anders Søgaard <[email protected]>
  • Loading branch information
andershagbard and andershagbard authored Jan 12, 2024
1 parent da19a8d commit 357becf
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions packages/hydrogen-react/src/ExternalVideo.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type {ExternalVideo as ExternalVideoType} from './storefront-api-types.js';
import type {PartialDeep} from 'type-fest';
import type {Entries, PartialDeep} from 'type-fest';

interface ExternalVideoBaseProps {
/**
Expand Down Expand Up @@ -40,9 +40,14 @@ export function ExternalVideo(props: ExternalVideoProps): JSX.Element {

if (options) {
const urlObject = new URL(data.embedUrl);
for (const key of Object.keys(options) as (keyof typeof options)[]) {
// @ts-expect-error https://github.com/microsoft/TypeScript/issues/32951
urlObject.searchParams.set(key, options[key]);
for (const [key, value] of Object.entries(options) as Entries<
typeof options
>) {
if (typeof value === 'undefined') {
continue;
}

urlObject.searchParams.set(key, value.toString());
}
finalUrl = urlObject.toString();
}
Expand Down

0 comments on commit 357becf

Please sign in to comment.