Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to resolve ts-expect-error comment in ExternalVideo #1418

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Refactor to resolve ts-expect-error comment in ExternalVideo #1418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/hydrogen-react/src/ExternalVideo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type {ExternalVideo as ExternalVideoType} from './storefront-api-types.js';
import type {PartialDeep} from 'type-fest';
import type {Entries, PartialDeep} from 'type-fest';

interface ExternalVideoBaseProps {
/**
Expand Down Expand Up @@ -40,9 +40,14 @@ export function ExternalVideo(props: ExternalVideoProps): JSX.Element {

if (options) {
const urlObject = new URL(data.embedUrl);
for (const key of Object.keys(options) as (keyof typeof options)[]) {
// @ts-expect-error https://github.com/microsoft/TypeScript/issues/32951
urlObject.searchParams.set(key, options[key]);
for (const [key, value] of Object.entries(options) as Entries<
typeof options
>) {
if (typeof value === 'undefined') {
continue;
}

urlObject.searchParams.set(key, value.toString());
}
finalUrl = urlObject.toString();
}
Expand Down