Remove error boundary from robots.txt skeleton #1492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
There was a bug fix introduced (see remix-run/remix#7538 (comment)) where routes exporting an
ErrorBoundary
are presumed not to be a resource route.When you generate a new hydrogen project and navigate to
/robots.txt
, you will get an "empty" page instead of the robots xml, and remix will warn:WHAT is this pull request doing?
Removing the
ErrorBoundary
from the generated hydrogen template