Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error boundary from robots.txt skeleton #1492

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

andrewcohen
Copy link
Contributor

WHY are these changes introduced?

There was a bug fix introduced (see remix-run/remix#7538 (comment)) where routes exporting an ErrorBoundary are presumed not to be a resource route.

When you generate a new hydrogen project and navigate to /robots.txt, you will get an "empty" page instead of the robots xml, and remix will warn:

Matched leaf route at location "/robots.txt" does not have an element or Component. This means it will render an <Outlet /> with a null value by default resulting in an "empty" page.

WHAT is this pull request doing?

Removing the ErrorBoundary from the generated hydrogen template

Copy link
Member

@benjaminsehl benjaminsehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for flagging & fixing this!

Copy link
Contributor

@wizardlyhel wizardlyhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run npm run changeset and add @hydrogen/cli amd @hydrogen/create-hydrogen for patch release.
Please also sign the Contributor License Agreement

@andrewcohen
Copy link
Contributor Author

I have signed the CLA!

@wizardlyhel
Copy link
Contributor

@andrewcohen Did you use the same github account to sign the CLA?

@andrewcohen
Copy link
Contributor Author

Yes
Screenshot 2023-11-08 at 12 46 36 PM

@wizardlyhel wizardlyhel merged commit 26c969b into Shopify:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants