-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
passing customer login to checkout fix #1719
Conversation
bc7c7c6
to
c404511
Compare
c404511
to
ae89e64
Compare
const {nonce, header, NonceProvider} = createContentSecurityPolicy({ | ||
connectSrc: [ | ||
'wss://<your-ngrok-domain.app:*', // Change with your ngrok domain | ||
], | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having this in the code feels really strange since it is only for development and only relevant if you are doing anything customer account related. Can I remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can make it so you put in the domain during npm run dev --ngrok-domain=accepted-shrimp-privately.ngrok-free.app
this will automatically start ngrok for you, do the domain change and change dev up message too.
it will mean that our shopify hydrogen dev
will depend on ngrok. Lets discuss in a separate PR since its outside of the scope of the current task
c132b71
to
d6f3e35
Compare
d6f3e35
to
a4b4c17
Compare
e43024d
to
f8d061e
Compare
359e413
to
b08574e
Compare
b08574e
to
1c9072a
Compare
1c9072a
to
64466bb
Compare
64466bb
to
80711e1
Compare
WHY are these changes introduced?
A bug was found where the logged-in customer status is not passed to checkout. This is because the customer access token from Customer Account API cannot be passed to storefront API as buyer identify.
WHAT is this pull request doing?
In skeleton
logged_in =true
query param to checkout link. Instructions from https://shopify.dev/docs/api/customer#step-stay-authenticated-on-checkoutHOW to test your changes?
Post-merge steps
Checklist