Move Codegen dependencies to templates #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
blittle
reviewed
Apr 9, 2024
| "dev": "shopify hydrogen dev --codegen", | ||
| "dev": "shopify hydrogen dev", |
There was a problem hiding this comment.
Yeah this caught my attention too.
There was a problem hiding this comment.
This is in hello-world template. This template is not yet even updated to Vite, and it does not have generated types for queries. Instead of adding the codegen dependencies in this template, I'm just removing the --codegen flag to keep it minimal 🤔
blittle
approved these changes
Apr 9, 2024
juanpprieto
approved these changes
Apr 9, 2024
| "dev": "shopify hydrogen dev --codegen", | ||
| "dev": "shopify hydrogen dev", |
There was a problem hiding this comment.
Yeah this caught my attention too.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have been running codegen for a while and it seems robust, it's time to move the dependencies to the template.
This will make creating new projects a bit faster since we don't need to install all the GraphQL / Codegen sub dependencies globally.