Fix type generation for types named AttachedClass that are not T::Types::AttachedClassType
#2005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When defining a class named
AttachedClass
, Tapioca is incorrectly generating it as if it was the typeT.attached_class
.So for the following Ruby code:
Tapioca would generate the following RBI which is incorrect:
Implementation
The
gsub
on the type name was a workaround until we merged sorbet/sorbet#3380 insorbet-runtime
, this is now unnecessary and is actually broken. We can just remove it.Tests
See automated tests.