[Tapioca Add-on] Trigger ActiveSupport::TestCase DSL compiler on fixture changes
#2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/watch-for-yaml-changes
branch
from
3efd5d3 to
82e2ec7
Compare
|
I still need to test on Core but feel free to review. |
andyw8
force-pushed
the
andyw8/watch-for-yaml-changes
branch
from
82e2ec7 to
3ca8695
Compare
andyw8
commented
Jan 27, 2025
andyw8
force-pushed
the
andyw8/watch-for-yaml-changes
branch
from
3ca8695 to
64a97f3
Compare
vinistock
approved these changes
Jan 27, 2025
KaanOzkan
reviewed
Jan 27, 2025
andyw8
force-pushed
the
andyw8/watch-for-yaml-changes
branch
2 times, most recently
from
cd353e3 to
3254f25
Compare
KaanOzkan
changed the title
ActiveSupport::TestCase DSL compiler on fixture changesActiveSupport::TestCase DSL compiler on fixture changes
KaanOzkan
approved these changes
Jan 27, 2025
andyw8
force-pushed
the
andyw8/watch-for-yaml-changes
branch
from
9613eaf to
2521a35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/Shopify/team-ruby-dx/issues/1305
TODO:
Verify performance in CoreNote: This doesn't work on Core because the fixtures is compiler is disabled and Core uses a custom compiler.