Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js-ipfs-api is now modular. Consider merging efforts? #6

Closed
daviddias opened this issue Aug 23, 2017 · 2 comments
Closed

js-ipfs-api is now modular. Consider merging efforts? #6

daviddias opened this issue Aug 23, 2017 · 2 comments

Comments

@daviddias
Copy link

Hi @SilentCicero! Really like what you demonstrated with this repo, it is true that some users might not need the whole js-ipfs-api bundle and therefore they can get a way reduced bundle size by just importing the functions they need.

With that in mind, @nunofmn went ahead and made js-ipfs-api modular, just like async or lodash, now you can require only the bundle you need with:

require('ipfs-api/src/bootstrap')

Or even, just require a function of the set with:

require('ipfs-api/object/patch/add-link')

This results in lot smaller bundle sizes, see the table: ipfs-inactive/js-ipfs-http-client#584 (comment)

And we are even going to make it smaller with: ipfs-inactive/js-ipfs-http-client#522 once ipfs/kubo#4008 is released in go-ipfs 0.4.11.

Would you consider focusing efforts in js-ipfs-api and keep doing work to make each submodular as smaller as possible? This would save a ton of work from updating two client libraries and would add a lot more test coverage.

Let me know what you think :)

@SilentCicero
Copy link
Owner

@diasdavid heyo, certainly! We should talk. Can you message me on gitter? Apologies for the late reply.

@daviddias
Copy link
Author

No problem. Just pinged you there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants