Return the size of each file on ipfs add

[daviddias]

@whyrusleeping would you be ok with adding one more value on the response of an ipfs add? The respective file size.

This would enable us to greatly reduce the bundle size of ipfs-api/add, which is what most users need.

[whyrusleeping]

@diasdavid would you want something returned for directories and symlinks?

[daviddias]

@whyrusleeping I feel it is useful to have the 'size' for those. Essentially I just grab the cumulative size https://github.com/ipld/js-ipld-dag-pb/blob/master/src/dag.proto.js#L13

[whyrusleeping]

@diasdavid alright, and you just want a "size":12345 field added to the response object? Do you want it to be a number or a string?

[daviddias]

Let's do a string because you know

[ghost]

👍 on including that, both the ls and object/stat commands return numbers though. Might be worth it to be consistent?

[Kubuxu]

It might be worth migrating away from returning numbers in JSON, to prevent stuff like #3354

[ghost]

Which issue do you mean? 4008 is this one here

[Kubuxu]

Sorry #3354

[whyrusleeping]

@lgierth I think we should try to migrate numbers in our api to be strings. It would be a breaking change, but i think its pretty important. This is probably worth opening its own issue over

[kristianfreeman]

Hey all! Can this be closed with #4082 being merged?