-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for custom event publishing strategy #8
Conversation
8c83bf4
to
868cd0f
Compare
@matthiasnoback what do You think? |
Hi @prgTW I'm the new maintainer of the The The idea behind this is that you can have multiple event listeners on the same event and this is the reason that we have the We could allow the change you did to make the service configurable but the |
868cd0f
to
da995ef
Compare
@cmodijk thanks for Your reply. You were absolutely correct of that the 'unhandled' strategy will not work so I followed Your comment and left only the ability for custom strategy support - after all it's enough for customizations. I've updated the code, pull request title and description. I hope everything is ok now :) |
@prgTW Yes, thanks for this. One question i have personally what method are going to implement if this get's merged? ps; I will get back to you in a few days to review it and merge it. |
@cmodijk I'm going to implement a complete opposite strategy to In my system I have something like internal and external events. External events are for 3rd party systems and therefore should use |
Merged! I'm doing some small stuff tonight i hope to create a release later this evening. |
looking forward then, thanks :) |
@prgTW Done, release 2.2.0 is out |
There are 2 strategies of handling events:
always
andpredefined
. I've added ability to define custom one (using a backward compatible configuration).TODO
Related
Related to: #6