Use Shared props/targets

[JimBobSquarePants]

Prerequisites

• I have written a descriptive pull-request title
• I have verified that there are no overlapping pull-requests open
• I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
• I have provided test coverage for my change (where applicable)

Description

• Updates the solution to use the shared props/targets
• Cleans up all warnings in the solution.
• Adds Mac OSX CI workflow plus additional enhancements from ImageSharp.

[codecov]

Codecov Report

Merging #111 (f9b7929) into master (3d737b5) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   70.82%   71.01%   +0.19%     
==========================================
  Files          86       86              
  Lines        5600     5465     -135     
  Branches     1119     1119              
==========================================
- Hits         3966     3881      -85     
+ Misses       1409     1359      -50     
  Partials      225      225              

Flag	Coverage Δ
unittests	71.01% <ø> (+0.19%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rc/ImageSharp.Drawing/Shapes/RectangularPolygon.cs	88.19% <0.00%> (-0.55%)	⬇️
src/ImageSharp.Drawing/Processing/SolidBrush.cs	92.10% <0.00%> (-0.40%)	⬇️
src/ImageSharp.Drawing/Processing/PatternBrush.cs	85.41% <0.00%> (-0.30%)	⬇️
src/ImageSharp.Drawing/Shapes/Star.cs	92.30% <0.00%> (-0.29%)	⬇️
src/ImageSharp.Drawing/Shapes/ComplexPolygon.cs	74.78% <0.00%> (-0.22%)	⬇️
...arp.Drawing/Shapes/Rasterization/ActiveEdgeList.cs	98.14% <0.00%> (-0.15%)	⬇️
src/ImageSharp.Drawing/Shapes/Clipper/clipper.cs	48.08% <0.00%> (-0.12%)	⬇️
src/ImageSharp.Drawing/Shapes/InternalPath.cs	90.22% <0.00%> (-0.11%)	⬇️
src/ImageSharp.Drawing/Shapes/Outliner.cs	95.40% <0.00%> (-0.11%)	⬇️
src/ImageSharp.Drawing/Shapes/PathBuilder.cs	93.58% <0.00%> (-0.09%)	⬇️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d737b5...f9b7929. Read the comment docs.

[antonfirsov]

Didn't get to drawing yet, but I see 999 build warnings in main lib's ImageSharp.Test project per build target. We should fix that before propagating the changes further.

Most of them are "this should not follow that" and underscore rules, not applicable in test code.

[JimBobSquarePants]

Didn't get to drawing yet, but I see 999 build warnings in main lib's ImageSharp.Test project per build target. We should fix that before propagating the changes further.

I don't think your submodule is loaded properly or something. I brought it down to zero from over 1200 warnings.

[antonfirsov]

@JimBobSquarePants ah sorry you may be right will doublecheck tomorrow! Forgot that sobmodule update typically goes always wrong 😅

[antonfirsov]

@JimBobSquarePants this ImageSharp.Drawing PR is fine, but still I get those warnings dotnet build-ing the main library's test project even on a fresh clone on master. (After standard git submodule update --init --recursive).

Nice job cleaning up the Drawing project, and the overall effort across the SixLabors infra. No idea why is it OK here and not OK in ImageSharp.

[antonfirsov]

Opened SixLabors/ImageSharp#1460 to properly track the problem.