-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Tiff support. #12
Comments
From @kierenj on September 7, 2016 20:27 I realise how unhelpful this comment right here is, but TIFF decoding across the board can be really tricky to get right - there are loads of compression formats, and even fairly respected tools (from MS / Atalasoft) get it wrong even with 1-bit images. I think some archiving formats even require special licensing to implement correctly. It might be worth identifying a small subset of formats to support! |
@kierenj It's certainly not an unhelpful comment. Tiff would be hard and I'm sorely tempted to let someone else figure it out and concentrate on what we have already. I'm just dreading the day someone tells me that the library is useless without it. There's always someone! |
I needed to import Tiff files so I created a temporary Tiff encoder and decoder based on LibTiff.Net. |
@ChrisVanDijk Good effort but have you benchmarked that codec? The Bitmiracle jpeg codec was about 10x slower and used 190MB more to process a small test image compared to our codec. I imagine the Tiff one will be the same. I'd be careful using it. @Andy-Wilkinson you have been playing around with Tiff haven't you with your own stuff? I wonder if we can use some of it? |
@JimBobSquarePants The code and performance is bad, but I really needed the ability to open Tiff files. It's a temporary solution until a better one. |
@ChrisVanDijk understandable. Tiff is a complex format so I'm pushing it to the backburner until I can get everything else out of the way... Not looking forward to tackling it! |
@ChrisVanDijk @JimBobSquarePants One big "advantage" of these naive C ports is that its really not that hard to make the first steps towards speeding & cleaning them up. |
@JimBobSquarePants I've got the basics of reading the Tiff format itself working from my own project (I started here since many Camera Raw files are mutant Tiff files). As you mention, there are a number of compression formats, but the key ones probably aren't too much trouble. The one issue with my existing codebase is that it was a bit of an experiment in a more functional style of C#, rather than how you might structure it normally. All that said, I know a fair amount about the Tiff format now, so probably would be able to make a quick start on a true ImageSharp Tiff codec pretty easily (and share a bit of the code where I can). Would you be interested in me picking up this issue and giving it a start? (especially since you guys seem to be busy enough with the existing codec perf 😄) |
@antonfirsov I've found with those ports though there's about a million lines more code than I'd like to read nested in there. @Andy-Wilkinson That would be absolutely brilliant if you could! 💯 |
I come across this library https://github.com/BitMiracle/libtiff.net which is already .netstandard compatible. I feel like this is a good candidate to bring support for TIFF. What do you think? |
@poeman16 : Unfortunately I've had pretty much zero time to devote to working on this pull request for a while. The foundations of parsing the TIFF structure was mostly in place, with the most complex area remaining being implementations for the different compression formations, in particular those based on JPEG. There would need to be some changes to fit with any changes in the ImageSharp design since the last commit. Definitely something that could be picked up by someone. |
There's been a lot of changes in the main repo since the PR was opened. We'll have to do a lot of work to update the codebase before support can be completed. |
Are there any plans to support TIFF in the future, im using your library for viewing/editing Exif data |
Yep, we have a Tiff branch with a lot of code written already. Post v1 we will work to complete it. |
Hi @JimBobSquarePants |
@antonfirsov @JimBobSquarePants @Andy-Wilkinson Can I contribute to the tiff-codec branch? |
@IldarKhayrutdinov that would be ace! 🚀 |
#12 Tiff specific fixes for LZW
#12 Implement Tiff Encoder benchmarks
#12 Use exif reader for tiff tags reading
#12 Support multi strip encoding. Improve performance and memory usage.
#12 Tiff specific fixes for LZW
#12 Implement Tiff Encoder benchmarks
#12 Use exif reader for tiff tags reading
#12 Support multi strip encoding. Improve performance and memory usage.
I am happy to announce that we have now support for decoding and encoding Tiff images with #1553 merged to the master branch. You can try it out with our nightly build from our myget feed For now this feature has to be activated manually by the user, which can be done in several different ways:
|
@brianpopow let’s make that automatic. 🙂 |
With #1634 merged, the Tiff format is now added to the default Configuration. |
Hi, i try to read a tiff image, but it throw |
No plans currently. That would require community support to implement. |
From @JimBobSquarePants on August 31, 2016 1:49
We should be able to support TIFF
Useful links.
http://partners.adobe.com/public/developer/tiff/index.html
http://www.remotesensing.org/libtiff/
http://www.awaresystems.be/imaging/tiff.html
Current implementation can be found in the tiff-codec branch.
Feature Checklist
Compression Types
Photometric Interpretation Formats
The text was updated successfully, but these errors were encountered: