Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JpegDecoderTests.Decode_IsCancellable is flaky on CI #1414

Closed
4 tasks done
antonfirsov opened this issue Nov 6, 2020 · 0 comments · Fixed by #1415
Closed
4 tasks done

JpegDecoderTests.Decode_IsCancellable is flaky on CI #1414

antonfirsov opened this issue Nov 6, 2020 · 0 comments · Fixed by #1415
Labels
unit tests
Milestone
Future

Comments

@antonfirsov
Copy link
Member

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of ImageSharp
  • I have verified if the problem exist in both DEBUG and RELEASE mode
  • I have searched open and closed issues to ensure it has not already been reported

Description

It's good to have a test for this IMO, however the sporadic CI failures are annoying.
Idea: add a retry loop around it, observe cancellation at least once from 5 runs.
@antonfirsov antonfirsov added this to the Future milestone Nov 6, 2020
antonfirsov added a commit that referenced this issue Nov 6, 2020
@antonfirsov
Fix #1414
5748d3d
@antonfirsov antonfirsov mentioned this issue Nov 6, 2020
Merged
4 tasks
JimBobSquarePants pushed a commit that referenced this issue Mar 13, 2021
@antonfirsov
Fix #1414
4812a8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unit tests
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Fix JpegDecoderTests.Decode_IsCancellable SixLabors/ImageSharp
1 participant
@antonfirsov